[OGUI-1674] Add deployment controller and endpoint - #2999
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a deployment controller and endpoint to enable environment deployments via the AliECS system. The implementation includes proper validation, authentication, and authorization checks to ensure only authorized users with the required locks can initiate deployments.
- Adds a new
DeploymentControllerthat validates deployment requests and interfaces with a deployment service - Implements a new POST
/deployendpoint with comprehensive middleware for authentication, authorization, and logging - Introduces proper request validation requiring either
workflowTemplateorselectedConfigurationparameters
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Control/lib/api.js | Integrates the new deployment controller and endpoint with required middleware chain |
| Control/lib/controllers/Deployment.controller.js | Implements the deployment controller with request validation and error handling |
| Control/lib/middleware/logDeploymentRequest.middleware.js | Adds middleware for logging deployment requests with user context |
| Control/lib/typedefs/DeploymentRequest.js | Defines the TypeScript-style typedef for deployment request structure |
| Control/test/lib/controllers/mocha-deployment.controller.js | Unit tests for the deployment controller functionality |
| Control/test/api/deployment/api-post-deployment.test.js | Integration tests for the deployment API endpoint |
| Control/test/mocha-index.js | Includes the new test files in the test suite |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
PR which: